Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defnition list in a defintion list is detected too late #87

Closed
miekg opened this issue Aug 25, 2018 · 3 comments
Closed

Defnition list in a defintion list is detected too late #87

miekg opened this issue Aug 25, 2018 · 3 comments

Comments

@miekg
Copy link
Collaborator

miekg commented Aug 25, 2018

A
:   This is A.

    b
    :   b1
 
    c
    :   c1
 
    d
    :   d1

Makes b part of the paragraph belonging to 'This is A.'. If you print the AST you get:

Document ''
    List ''
        ListItem ''
            Paragraph ''
                Text 'A'
        ListItem ''
            Paragraph ''
                Text 'This is A.'
            Paragraph ''
                Text 'b'
            List ''
                ListItem ''
                    Paragraph ''
                        Text 'b1'
                ListItem ''
                    Paragraph ''
                        Text 'c'
                ListItem ''
                    Paragraph ''
                        Text 'c1'
                ListItem ''
                    Paragraph ''
                        Text 'd'
                ListItem ''
                    Paragraph ''
                        Text 'd1'
@miekg
Copy link
Collaborator Author

miekg commented Aug 26, 2018

blackfriday v1 branch has same problem:

% ./blackfriday-tool ~/test.md
<dl>
<dt>A</dt>
<dd><p>This is A.</p>

<p>b</p>

<dl>
<dd>b1</dd>
<dt>c</dt>
<dd>c1</dd>
<dt>d</dt>
<dd>d1</dd>
</dl></dd>
</dl>

@miekg
Copy link
Collaborator Author

miekg commented Aug 26, 2018

haha, lol it's this: russross/blackfriday#263

@miekg
Copy link
Collaborator Author

miekg commented Oct 25, 2018

this was fix, currently we get:

Document ''
    List ''
        ListItem ''
            Paragraph ''
                Text 'A'
        ListItem ''
            Paragraph ''
                Text 'This is A.'
            List ''
                ListItem ''
                    Paragraph ''
                        Text 'b'
                ListItem ''
                    Paragraph ''
                        Text 'b1'
                ListItem ''
                    Paragraph ''
                        Text 'c'
                ListItem ''
                    Paragraph ''
                        Text 'c1'
                ListItem ''
                    Paragraph ''
                        Text 'd'
                ListItem ''
                    Paragraph ''
                        Text 'd1'

@miekg miekg closed this as completed Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant