Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Congratulations and questions #42

Closed
frederikhors opened this issue Feb 23, 2022 · 3 comments
Closed

Congratulations and questions #42

frederikhors opened this issue Feb 23, 2022 · 3 comments
Assignees
Labels
⚡good first issue Good for newcomers ❓question Further information is requested

Comments

@frederikhors
Copy link

Congratulations for your work.

Can you please add benchmarks?

What do you think about https://bunrouter.uptrace.dev?

@frederikhors frederikhors added the 📈enhancement New feature or request label Feb 23, 2022
@apoorvcodes
Copy link
Member

Hey there, I have already checked out burnrouter looks very good we were thinking to have something similar like it, and as per benchmarks we haven't done a lot of em, but we use hash-table for the url matching which will be on par with radix tree so basically very performant. We still are in testing and bug fixing stages so expect some problems here and there, Thanks for your interest in gominima

@apoorvcodes apoorvcodes added ⚡good first issue Good for newcomers ❓question Further information is requested and removed 📈enhancement New feature or request labels Feb 24, 2022
@apoorvcodes
Copy link
Member

Also if you want benchmarks we are open for a pr for that

@apoorvcodes
Copy link
Member

Due to no more response closing this issue reopen if more queries! Have a nice day @frederikhors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡good first issue Good for newcomers ❓question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants