Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to remove modules from the storage #1004

Closed
marpio opened this issue Dec 18, 2018 · 3 comments
Closed

Add ability to remove modules from the storage #1004

marpio opened this issue Dec 18, 2018 · 3 comments
Labels
enhancement New feature or request proposal A proposal for discussion and possibly a vote
Milestone

Comments

@marpio
Copy link
Member

marpio commented Dec 18, 2018

Is your feature request related to a problem? Please describe.
Even though athens storage should be immutable, there are some cases where modules will have to be deleted i.e. due to a DMCA infringement.

Describe the solution you'd like
The storages already implements the Deleter interface, what's missing is an http endpoint. It might be an manual process only possible from the UI and only accessible to users with a specific permission.

@marpio marpio added enhancement New feature or request proposal A proposal for discussion and possibly a vote labels Dec 18, 2018
@marpio marpio added this to the v1.0.0 milestone Dec 18, 2018
@marpio marpio modified the milestones: v1.0.0, v0.3.0 Dec 18, 2018
@arschles
Copy link
Member

we'll need to have some authorization mechanism for deletes

@lopezator
Copy link
Contributor

This would be possible now, although not ideal, by using "basic auth".

I agree that we need something to delete specific packages in case something goes bad (bad checksum, corrupted package or whatever).

@arschles
Copy link
Member

We have external storage drivers now, so an external driver could be built, using the Athens pkg/storage packages, that supports deletions. I'm going to close this for now since there hasn't been activity here in a long time. If anyone comes across this issue and has a definitive use case to having Athens support deletions, please feel free to comment here or open up a new issue 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal A proposal for discussion and possibly a vote
Projects
None yet
Development

No branches or pull requests

3 participants