Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock out VCS/go get in order to improve testing speed #1368

Open
twexler opened this issue Sep 3, 2019 · 6 comments
Open

Mock out VCS/go get in order to improve testing speed #1368

twexler opened this issue Sep 3, 2019 · 6 comments
Labels
good first issue Great issues for new Athenians to work on!

Comments

@twexler
Copy link
Collaborator

twexler commented Sep 3, 2019

Is your feature request related to a problem? Please describe.
During office hours, we discussed testing athens, and it seemed like one issue is that we have to actually call out to somewhere public to run tests. This isn't ideal for several reasons.

Describe the solution you'd like
Ideally, this would just be a module.Fetcher implemented against a set of local filesystem objects

Describe alternatives you've considered
None considered

Additional context
Add any other context or screenshots about the feature request here.

@arschles arschles added the good first issue Great issues for new Athenians to work on! label Sep 3, 2019
@marwan-at-work
Copy link
Contributor

@twexler can you specify which tests exactly should be using a mock? I believe we do have a mock implementation of module.Fetcher but we also test the live-internet-y code for good reasons to make sure things function properly. I can help you look around if you're not sure which tests would you like to mock out. Thanks!

@yolocs
Copy link

yolocs commented Sep 4, 2019

Seems similar to #1359?

@twexler
Copy link
Collaborator Author

twexler commented Sep 4, 2019

@marwan-at-work I need to rewatch yesterday's office hours to regain context, but as mentioned this came up during that meeting

@twexler
Copy link
Collaborator Author

twexler commented Sep 4, 2019

@yolo3301 it seems fairly similar to that issue, maybe sort of a duplicate?

@arschles
Copy link
Member

arschles commented Sep 6, 2019

There could be two levels to this. a Mock VCS could help us isolate the caller / response parsing code from the code that sets up the command and environment. the mock binary in #1359 could validate the code to set up the command/env

@arschles
Copy link
Member

Seems similar to #1359?

@yolocs yes, I think this is exactly the same. #1449 should fix both of these issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Great issues for new Athenians to work on!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants