Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus service to Athens docker-compose #970

Open
t-tomalak opened this issue Dec 6, 2018 · 5 comments · May be fixed by #1113
Open

Add Prometheus service to Athens docker-compose #970

t-tomalak opened this issue Dec 6, 2018 · 5 comments · May be fixed by #1113
Labels
dev ux Improvements to the development or operator experience good first issue Great issues for new Athenians to work on!

Comments

@t-tomalak
Copy link
Member

Is your feature request related to a problem? Please describe.
As we support metrics export to prometheus (#816) we could add it as a service to our docker-compose

Describe the solution you'd like

There should be configured prometheus service in Athens docker-compose that will be listening on Athens metrics endpoint

Additional context
https://hub.docker.com/r/prom/prometheus/
https://prometheus.io/docs/prometheus/latest/configuration/configuration/

@ghost ghost added the dev ux Improvements to the development or operator experience label Dec 7, 2018
@michalpristas michalpristas added the good first issue Great issues for new Athenians to work on! label Jan 16, 2019
@vaibhavjayaraman
Copy link

Can I give this a shot?

@t-tomalak
Copy link
Member Author

Sure, go ahead!

@vaibhavjayaraman
Copy link

Sorry about the delay. I was busy with school work. I added a Prometheus service to the docker-compose file but I made a lot of hacky assumptions when writing the configuration file and updating the docker-compose file. Should I create a PR so that you guys can critic?

@michalpristas
Copy link
Member

sure @vaibhavjayaraman feel free to raise a PR and comment places where you need input from somebody, or something is unclear

@vaibhavjayaraman vaibhavjayaraman linked a pull request Mar 8, 2019 that will close this issue
@vaibhavjayaraman
Copy link

Cool. I raised a PR and commented on lines that I had immediate issues with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev ux Improvements to the development or operator experience good first issue Great issues for new Athenians to work on!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants