Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentinel support #11

Closed
garyburd opened this issue Jan 7, 2013 · 7 comments
Closed

Add sentinel support #11

garyburd opened this issue Jan 7, 2013 · 7 comments

Comments

@garyburd
Copy link
Member

garyburd commented Jan 7, 2013

http://redis.io/topics/sentinel-clients

I have a rough plan in mind on how to implement sentinel support, but I have not done it yet because I don't need it.

@simonklee
Copy link

I haven't really looked into the details of how Redis-sentinel works, but could use a sentinel aware client. What are your ideas on how to implement this. I wonder if it could be done quite ad-hoc albeit like what redis-py just merged [1].

[1] redis/redis-py@89d88d6

@garyburd
Copy link
Member Author

To be honest, I forgot what my plan was. The redis;py client looks reasonable.

I don't have immediate plans to work on this.

@simonklee
Copy link

Thanks for the response. I'll might make it my next weekend project.

@hbcheng
Copy link

hbcheng commented Mar 31, 2015

Hi, this feature is something that would improve our deployment and I'm willing to help out on this. Seeing as there hasn't been any noise on this in some time, I was wondering if:

a) There is any existing work on this that you or any of the contributors are aware of, and

b) If your thoughts on design or implementation have changed in the ~year and a half since this was last discussed.

@garyburd
Copy link
Member Author

garyburd commented Apr 6, 2015

For those following along on the issue tracker, @hbcheng is now taking a look at this feature.

@hbcheng
Copy link

hbcheng commented Apr 10, 2015

Pull request is submitted, pr #120.

@garyburd
Copy link
Member Author

I have no plans to add this feature. See the related projects list for sentinel implementations.

@gomodule gomodule locked and limited conversation to collaborators Dec 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants