Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird default type handling using Fprint #35

Closed
eaigner opened this issue Jul 18, 2013 · 2 comments
Closed

Weird default type handling using Fprint #35

eaigner opened this issue Jul 18, 2013 · 2 comments

Comments

@eaigner
Copy link

eaigner commented Jul 18, 2013

Redigo handles complex types by "converting" them using Fprint which seems like a very odd thing to do.

default:
  var buf bytes.Buffer
  fmt.Fprint(&buf, arg)

Why use Fprint when there is encoding/gob? I don't really understand the design decision here.

gob.NewEncoder(&buf).Encode(&arg)

would be more robust.

@garyburd
Copy link
Member

See issue #30.

@eaigner
Copy link
Author

eaigner commented Jul 18, 2013

Sorry for the dupe, don't know why I didn't see this.

@eaigner eaigner closed this as completed Jul 18, 2013
@gomodule gomodule locked and limited conversation to collaborators Dec 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants