This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Rails 4.0.0.beta1 compatibility #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated README. Fixed assocciation example as it was outdated and broken
- Update dependencies - Get rid of observers tests (I tried to use rails-observer gems but it was a mess) - Update deprecated calls like #scope or #default_scope without block - Get rid of attr_protected call and tests - Get rid of AR#destroy! NoMethodError test The last one cause issue because in AR 4 #destroy! bang is defined. It's the same as #destroy but raise an AR::RecordNotFound if the record is not present in database. It may be smart to find another name for this method. But for now it just works.
|
👍 |
|
@byroot, @goncalossilva, please review the PR I just sent: byroot/pull/1 |
belongs_to_with_deleted should pass scope to belongs_to_without_deleted
don't save when destroying a non persisted object
|
+1 |
|
+1 Rails 4.0.0.beta1 compatibility? |
|
+1, any news on it? |
|
+1 |
|
Hi guys, I'm going to be actively working on getting this gem compatible with Rails 4. I'm still getting through all the pull requests and issues but I'll keep you guys updated. |
|
+1 |
This branch targets Rails 4.0
|
+1 |
Closed
|
@christopherchiu any word on this? I'm working on upgrading an app to 4 and I'm not sure which fork to use. Anything I could do to help? |
Add Compatibility for Rails 4.1
|
We're working on this separately, and will be cherry-picking some of these commits separately. I'm going to close this since its still WIP. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last one cause issue because in AR 4 #destroy! bang is defined.
It's the same as #destroy but raise an AR::RecordNotFound if the record
is not present in database.
It may be smart to find another name for this method. But for now it just works.