Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygons don't meet when using N64-style depth compare and AA #1362

Closed
Aquatakat opened this issue Feb 7, 2017 · 19 comments
Closed

Polygons don't meet when using N64-style depth compare and AA #1362

Aquatakat opened this issue Feb 7, 2017 · 19 comments

Comments

@Aquatakat
Copy link
Contributor

This issue does not occur with XG-2

image

@Aquatakat Aquatakat changed the title Xtreme G polygons do not meet (refactor_graphics) Extreme G polygons do not meet (refactor_graphics) Feb 7, 2017
@gonetz
Copy link
Owner

gonetz commented Feb 7, 2017

Which build you are using for testing? The branch updated often.

@Aquatakat
Copy link
Contributor Author

184ff8f

@gonetz
Copy link
Owner

gonetz commented Feb 7, 2017

10 days old. Can you build current state?

@gonetz
Copy link
Owner

gonetz commented Feb 7, 2017

Please test with current build:
#1364

@Aquatakat
Copy link
Contributor Author

The problem hasn't changed with 8004dc2.

@AmbientMalice
Copy link
Contributor

That kinda looks like an accurate N64 depth issue.

@Aquatakat
Copy link
Contributor Author

You're right - it only happens when N64 depth compare is on.

@gonetz I'll let you close this issue if you like seeing as it's an experimental feature.

@AmbientMalice
Copy link
Contributor

Well, accurate N64 depth seems bugged with TWINE in this branch, so there's obviously something that needs fixing.

@oddMLan
Copy link
Contributor

oddMLan commented Feb 8, 2017

imagen
imagen

Could reproduce with AA enabled. With AA disabled it doesn't happen

@gonetz
Copy link
Owner

gonetz commented Feb 8, 2017

I tested accurate N64 depth with other games. It works for me and should work for you. I run it without AA.

@Aquatakat
Copy link
Contributor Author

Yes it's fine with AA disabled.

image

@AmbientMalice
Copy link
Contributor

I'm not using AA, and I'm getting a sort of shimmering distortion on objects in TWINE.

@Aquatakat Aquatakat changed the title Extreme G polygons do not meet (refactor_graphics) Polygons don't meet when using N64-style depth compare and AA (refactor_graphics) Feb 8, 2017
@Aquatakat
Copy link
Contributor Author

image

I changed the title

@gonetz
Copy link
Owner

gonetz commented Feb 13, 2017

@Aquatakat
Copy link
Contributor Author

Same problem unfortunately. I noticed the OSD works again though:

image

@Aquatakat
Copy link
Contributor Author

image

I've noticed that the problem is milder when using 2x AA, so maybe that means it's only happening on pixels that AA is trying to change?

@gonetz gonetz changed the title Polygons don't meet when using N64-style depth compare and AA (refactor_graphics) Polygons don't meet when using N64-style depth compare and AA Feb 14, 2017
@gonetz
Copy link
Owner

gonetz commented Feb 14, 2017

It is not refactor_graphics branch regression. Current Release works the same. It can be explained. Depth buffer is single sampled when N64 depth compare is on. Depth compare fails between polygons because its continuity becomes broken on polygons bounds in case of multisampling. I hardly can fix it, so lets consider it as "feature": N64 depth compare is incompatible with MSAA.

@Aquatakat
Copy link
Contributor Author

Sure.

@Frank-74
Copy link

Frank-74 commented Feb 14, 2017

I don't get the polygons don't meet with N64 depth compare and 2xAA problem. But I do get distant objects appearing in front of near objects. IntelHD Graphics. GL 4.0 support.

Pic taken with 2xAA and N64 depth compare enabled.
gliden64_extremeg_002
gliden64_extremeg_007

Used very latest 47cd2e8 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants