Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support internal pocketbase-images #28

Closed
tamaskan opened this issue Dec 2, 2023 · 5 comments
Closed

Support internal pocketbase-images #28

tamaskan opened this issue Dec 2, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@tamaskan
Copy link

tamaskan commented Dec 2, 2023

For docker-internal pocketbase-installations without a public domain some kind of proxy would be useful to avoid missing images.

@goniszewski
Copy link
Owner

Hello @tamaskan! I don't say no, but at the same time I don't have any plans for shipping integrated proxy.

However, if you have some experience configuring Caddy, Nginx, or any other solution to work this way, I would be more than eager to discuss how to expand the documentation with the necessary steps and configurations.

@tamaskan
Copy link
Author

tamaskan commented Dec 2, 2023

Is something like that https://vitejs.dev/config/server-options.html#server-proxy possible ? Basically have a proxy from like https://grimoire.domain/images to http://grimoire_internal . That should work with external and internal urls

@tamaskan
Copy link
Author

tamaskan commented Dec 2, 2023

another much simpler way would be to save the images in base64 and use that as fallback

@goniszewski
Copy link
Owner

I would have to check the limitations of the node adapter for SvelteKit. If it's doable with the current configuration, I'll add it to the backlog.

Storing images as blobs has also its set of disadvantages.

@goniszewski goniszewski added the enhancement New feature or request label Dec 6, 2023
@goniszewski
Copy link
Owner

The app will now proxy PocketBase API calls (including fetching the images) through /internal route: #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants