Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested ListViews trigger parent refresh indicator #3

Closed
kennethj opened this issue Jun 16, 2020 · 3 comments
Closed

Nested ListViews trigger parent refresh indicator #3

kennethj opened this issue Jun 16, 2020 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@kennethj
Copy link
Contributor

When you have add vertical scrolling list view with nested horizontal scrolling, if you overflow scroll one of the nested ListViews the parent refresh indicator is triggered.

It would nice to lock the pull to an axis or direction.

@gonuit
Copy link
Owner

gonuit commented Jun 18, 2020

Thank you for opening the problem.
I will check if this problem can be resolved in any other way than specifying a single scroll axis 🤔.

@gonuit gonuit self-assigned this Aug 12, 2020
@gonuit gonuit added bug Something isn't working enhancement New feature or request labels Aug 12, 2020
@gonuit
Copy link
Owner

gonuit commented Aug 12, 2020

@kennethj new package version (0.9.0-dev.1) is available on pub.dev.
Now it is possible to decide which scroll notifications will trigger indicator widget.

From this version CustomRefreshIndicator has a default notificationPredicate argument:

(notification) => notification.depth == 0,

CustomRefreshIndicator widget will by default listen for notifications with the depth equal to 0. Thanks for that nested ListViews will not trigger refresh indicator.

Let me know if it is what you were looking for and whether it solves your issue or not 💪

Have a nice day 😃 🌴

@gonuit
Copy link
Owner

gonuit commented Aug 21, 2020

I'm closing this issue as no further action is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants