Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature_request] add IndicatorState.completed #5

Closed
The-Redhat opened this issue Jul 30, 2020 · 6 comments
Closed

[feature_request] add IndicatorState.completed #5

The-Redhat opened this issue Jul 30, 2020 · 6 comments
Assignees
@gonuit
Labels
enhancement New feature or request

Comments

@The-Redhat
Copy link

The-Redhat commented Jul 30, 2020 •
edited

It would be nice to add an optional complete state which is shown after onRefresh has completed but before the indicator is hidden again. One could show for example a checkmark.
@gonuit
Copy link
Owner

gonuit commented Aug 12, 2020 •
edited

Hi @The-Redhat!
I'm working on this feature => stay tuned! 😃

@gonuit gonuit added the enhancement New feature or request label Aug 12, 2020
@gonuit gonuit self-assigned this Aug 12, 2020
@gonuit
Copy link
Owner

gonuit commented Aug 12, 2020

@The-Redhat, new dev package version is now available on pub.dev.
To use a complete state, depend on:

dependencies:
  custom_refresh_indicator: 0.9.0-dev.1

Example indicator [SOURCE CODE]:

example

@The-Redhat
Copy link
Author

Thanks man. I'll try it out.

@The-Redhat
Copy link
Author

Nice work. Maybe you could add an isComplete property similar to isHiding.

@gonuit
Copy link
Owner

gonuit commented Aug 15, 2020

That's right! I'll add it.

@gonuit
Copy link
Owner

gonuit commented Aug 21, 2020 •
edited

@The-Redhat isComplete and wasComplete properties are added and ready for tests!

dependencies:
  custom_refresh_indicator: 0.9.0

@gonuit gonuit closed this as completed Aug 21, 2020
@mzl1988 mzl1988 mentioned this issue Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gonuit gonuit

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@The-Redhat @gonuit