Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mat: Improvements to list_test testing behavior #741

Open
btracey opened this issue Sep 15, 2015 · 1 comment
Open

mat: Improvements to list_test testing behavior #741

btracey opened this issue Sep 15, 2015 · 1 comment

Comments

@btracey
Copy link
Member

btracey commented Sep 15, 2015

List test works by generating random matrices. We should improve this behavior by a) Having an inner loop where we test on a set of random matrices b) Instead of using rand.Float64() to generate random elements, we should instead use const*rand.NormFloat64()

Fix a) helps to check "nonlinear" functions like Max where the location of the maximum element can vary, and Fix b) ensures we have have matrix values of a variety of signs and sizes. Plausibly we also should have a small change of being 0 as well (5% or something).

@btracey
Copy link
Member Author

btracey commented Sep 15, 2015

ListTwoTest should also fill the entire data slice with values (or possibly NaN) for types like TriDense and SymDense as 0 is a pretty innocuous value with an incorrect access.

@btracey btracey changed the title Improvements to list_test testing behavior matrix/mat64: Improvements to list_test testing behavior Mar 16, 2017
@vladimir-ch vladimir-ch transferred this issue from gonum/matrix Dec 9, 2018
@vladimir-ch vladimir-ch changed the title matrix/mat64: Improvements to list_test testing behavior mat: Improvements to list_test testing behavior Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant