Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lapack/testlapack: rationalise helpers #678

Closed
kortschak opened this issue Feb 3, 2017 · 3 comments
Closed

lapack/testlapack: rationalise helpers #678

kortschak opened this issue Feb 3, 2017 · 3 comments
Assignees

Comments

@kortschak
Copy link
Member

There are a variety of helpers in testlapack that can be used but are not (for example isOrthonormal). I have contributed to this, but it should probably be cleaned up/factored out.

In the case of isOrthonormal the in-line implementations, e.g. in dgelq2.go, do more and have difference tolerances to isOrthonormal, These parameterisations might want to be incorporated into the general.go helper.

@btracey btracey changed the title testlapack: rationalise helpers lapack/testlapack: rationalise helpers Mar 16, 2017
@vladimir-ch vladimir-ch transferred this issue from gonum/lapack Nov 23, 2018
@vladimir-ch
Copy link
Member

isOrthonormal has been done but is there anything else that you'd like to include here? The contents of general.go and matgen.go could be improved but again, where to stop and where is best to invest time?

@vladimir-ch vladimir-ch self-assigned this Feb 10, 2019
@kortschak
Copy link
Member Author

I'm pretty happy with how things are now. The test code is vastly more readable (thank you) and what remains can be done as it's noticed/cared about.

@vladimir-ch
Copy link
Member

Does it mean we can close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants