LinkedTaskChannel.subscribe(), explicit asyncio task cancel logging, test_trioisms.py
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
changed the title
asyncio task explicit task cancelsasyncio task cancel logging
goodboy
changed the title
asyncio task cancel loggingLinkedTaskChannel.subscribe() and Explicit asyncio` task cancel logging
goodboy
changed the title
LinkedTaskChannel.subscribe() and Explicit asyncio` task cancel loggingLinkedTaskChannel.subscribe() and Explicit asyncio task cancel logging
goodboy
force-pushed
the
aio_explicit_task_cancels
branch
from
bacb9a5
to
7205702
Compare
When an `asyncio` side task errors or is cancelled we now explicitly report the traceback and task name if possible as well as the source reason for the error (some come from the `trio` side). Further, properly set any `trio` side exception (after unwrapping it from the `outcome.Error`) on the future that runs the `trio` guest run.
goodboy
force-pushed
the
aio_explicit_task_cancels
branch
from
7205702
to
032e14e
Compare
goodboy
changed the title
LinkedTaskChannel.subscribe() and Explicit asyncio task cancel loggingLinkedTaskChannel.subscribe(), explicit asyncio task cancel logging, test_trioisms.py
goodboy
force-pushed
the
aio_explicit_task_cancels
branch
2 times, most recently
from
0392e74
to
edfb25e
Compare
goodboy
force-pushed
the
aio_explicit_task_cancels
branch
from
edfb25e
to
fa354ff
Compare
goodboy
force-pushed
the
aio_explicit_task_cancels
branch
from
382deb2
to
9c27858
Compare
|
Lul no idea but now windows wants to pass, k. |
This was referenced Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically 2 parts:
to_asyncio.LinkedTaskChannel.subscribe()which gives task-oriented broadcast functionality semantically equivalent toMsgStream.subscribe()trio-side tasks to consumeasyncio-side task msgs in tandemThis work was originally inspired as part of debugging a case in
piker's service manager that ended up leading to python-trio/trio#2258.Included is a test that demonstrates the current
triobehaviour in a newtest_trioisms.pyfor tracking such situations in the future.TODO:
LinkedTaskChannel.subscribe()support