Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trio.MultiError is deprecated -> move to exceptiongroup.ExceptionGroup #332

Closed
goodboy opened this issue Oct 8, 2022 · 1 comment
Closed

trio.MultiError is deprecated -> move to exceptiongroup.ExceptionGroup #332

goodboy opened this issue Oct 8, 2022 · 1 comment
Labels
infra

Comments

@goodboy
Copy link
Owner

goodboy commented Oct 8, 2022 •
edited
Loading

This is killing CI: https://github.com/goodboy/tractor/actions/runs/3207101811/jobs/5241628100

test_multierror_assert.py::test_bad_assert
  /home/goodboy/repos/tractor/test_multierror_assert.py:32: TrioDeprecationWarning: trio.NonBaseMultiError is deprecated since Trio 0.22.0; use ExceptionGroup (on Python 3.11 and later) or exceptiongroup.ExceptionGroup (earlier versions) instead (https://github.com/python-trio/trio/issues/2211)
    assert trio.NonBaseMultiError is trio.MultiError

Have repro-ed this locally
@goodboy goodboy added the infra label Oct 8, 2022
@goodboy goodboy changed the title Weird exception group issue in CI trio.MultiError is deprecated -> move to exceptiongroup.ExceptionGroup Oct 8, 2022
@goodboy goodboy mentioned this issue Oct 9, 2022
Merged
@goodboy
Copy link
Owner Author

goodboy commented Oct 17, 2022

Closed by #333

@goodboy goodboy closed this as completed Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goodboy