Remove Makefile.PL options which are not needed and fix env names #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBD::MariaDB already correctly detects SSL/TLS support at compile time and runtime, so there is no need to manually disabling SSL/TLS at configure time.
Behavior from this option can be already configured at runtime via mariadb_client_found_rows connection attribute. And --nofoundrows was broken in DBD::mysql since commit f2aa689.
All relevant tests are already written in way that test both server side prepared statements and client side placeholder emulation. So there is no need to explicitly set mariadb_server_prepare=1 just for test suite.
Despite its description in Makefile.PL it affected only test suite. As there are already tests which check that mariadb_bind_type_guessing is working, there is no need for such option in Makefile.PL anymore.
Setting this variable does nothing since commit 0937d8c. Also option --ps-protocol was removed from Makefile.PL therefore we do not need this functionality anymore.
This is needed to ensure that DBD::mysql and DBD::MariaDB can coexist and be installed at the same time on one machine without any collision.
branislav-zahradnik-gdc
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.