Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DKL-DI-0003 should be removed #110

Closed
sotoiwa opened this issue Apr 13, 2021 · 1 comment
Closed

DKL-DI-0003 should be removed #110

sotoiwa opened this issue Apr 13, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@sotoiwa
Copy link

sotoiwa commented Apr 13, 2021

The best practice of avoiding apt-get upgrade in Dockerfile has been removed from Docker's documentation. Dockle should also remove this check by default.

https://github.com/goodwithtech/dockle/blob/master/CHECKPOINT.md#dkl-di-0003

Hadolint has already removed this check. Please see the discussion in the following link.

docker/docs#12571
hadolint/hadolint#562
@sotoiwa sotoiwa added the enhancement New feature or request label Apr 13, 2021
@tomoyamachi tomoyamachi mentioned this issue Apr 23, 2021
Merged
@tomoyamachi
Copy link
Collaborator

tomoyamachi commented Apr 23, 2021 •
edited

@sotoiwa Thank you for the report! I did not know that.

I modified DKL-DI-0003. Dockle v0.3.12 allows apt-get upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomoyamachi @sotoiwa