Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use stable version of abseil? #264

Closed
zjuturtle opened this issue Nov 21, 2019 · 3 comments
Closed

Why not use stable version of abseil? #264

zjuturtle opened this issue Nov 21, 2019 · 3 comments

Comments

@zjuturtle
Copy link

zjuturtle commented Nov 21, 2019

I notice in WORKSPACE, there is a TODO

# Head commit on 2019-04-12.
# TODO: Switch to the latest absl version when the problem gets
# fixed.

What is the problem exactly?

@jiuqiant
Copy link
Collaborator

There is an inconsistent Bazel config setting between mediapipe and abseil. Does the current abseil dependency cause any problem to you?

Moreover, abseil has three LTS versions (lts_2018_06_20, lts_2018_12_18, and lts_2019_08_08). Do you suggest that MediaPipe needs to depend on abseil's lts_2019_08_08? We avoid depending on the master branch of abseil since any changes in the master branch invalid the build cache and everything needs to be rebuilt again.

@zjuturtle
Copy link
Author

Currently I have not encountered any problem, it is just a little wired to use a snapshot version dependency. I think I'll suggest to use lts_2019_08_08 version.
Thank you!

@jiuqiant
Copy link
Collaborator

jiuqiant commented Dec 3, 2019

Fixed in 137867d.

@jiuqiant jiuqiant closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants