Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose IrisToDepthCalculator in Python #4189

Open
cancan101 opened this issue Mar 22, 2023 · 3 comments
Open

Expose IrisToDepthCalculator in Python #4189

cancan101 opened this issue Mar 22, 2023 · 3 comments
Assignees
Labels
legacy:iris Issues related to Iris platform:python MediaPipe Python issues stat:awaiting googler Waiting for Google Engineer's Response type:feature Enhancement in the New Functionality or Request for a New Solution

Comments

@cancan101
Copy link

cancan101 commented Mar 22, 2023

MediaPipe Solution (you are using)

No response

Programming language

Python

Are you willing to contribute it

Yes

Describe the feature and the current behaviour/state

IrisToDepthCalculator, which takes the iris landmarks and returns the depth of the iris from the camera is not currently exposed in Python. Iris landmarks themselves are now exposed in python and it would be great if these could then be converted to depths.

Will this change the current API? How?

No response

Who will benefit with this feature?

No response

Please specify the use cases for this feature

The ability to experiment in Python with iris depth estimation.

Any Other info

Related tickets:

and would avoid developers from having to re-invent the wheel: https://github.com/Rassibassi/mediapipeDemos/blob/47c6330227c88ca02e32deb47b150aa8391306a4/custom/iris_lm_depth.py#L112-L123

@cancan101 cancan101 added the type:feature Enhancement in the New Functionality or Request for a New Solution label Mar 22, 2023
@kuaashish kuaashish added platform:python MediaPipe Python issues legacy:iris Issues related to Iris labels Mar 27, 2023
@kuaashish
Copy link
Collaborator

Hi @cancan101,
Thank you raising this feature request. Could you please point out the use case about this feature that will be more helpful to understand the request better and we can bring up to notice of the team. Thank you!

@kuaashish kuaashish added the stat:awaiting response Waiting for user response label Mar 29, 2023
@cancan101
Copy link
Author

cancan101 commented Mar 30, 2023

It can allow depth calculations without needing specialized hardware for the distance from the camera to a human face. For experimentation with these techniques it is helpful to have the algorithm exposed in Python rather than just in C++. As evidenced by the linked repository, given that the Iris depth logic has been (partially) re-implemented in Python, there is clearly a desire for this functionality in the community.

Linking to Google Blog Post the discussed the feature in general: https://ai.googleblog.com/2020/08/mediapipe-iris-real-time-iris-tracking.html.

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Waiting for user response label Mar 30, 2023
@kuaashish kuaashish added the stat:awaiting googler Waiting for Google Engineer's Response label Mar 31, 2023
@schmidt-sebastian
Copy link
Collaborator

Thank you for this feature request. We are a bit swamped at the moment but will add this to our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy:iris Issues related to Iris platform:python MediaPipe Python issues stat:awaiting googler Waiting for Google Engineer's Response type:feature Enhancement in the New Functionality or Request for a New Solution
Projects
None yet
Development

No branches or pull requests

3 participants