Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off by one error in Polygen? #72

Closed
wamiq-reyaz opened this issue Aug 30, 2020 · 1 comment
Closed

Off by one error in Polygen? #72

wamiq-reyaz opened this issue Aug 30, 2020 · 1 comment

Comments

@wamiq-reyaz
Copy link

wamiq-reyaz commented Aug 30, 2020

If we look at this line, we see that the input sequence is padded on the right.

And in order to generate the predictive distribution, we do this , which makes sense - the last element in the sequence is not used for prediction. But then in an autoregressive setting, I would assume that you would have element 0, a_0 predict a_1 and so on.

In the training script, we have

vertex_model_loss = -tf.reduce_sum( vertex_model_pred_dist.log_prob(vertex_model_batch['vertices_flat']) * vertex_model_batch['vertices_flat_mask'])

This does not make sense to me. This would mean we are using the current element to predict itself. This has zero generative power, right?
@saran-t @charlienash

@wamiq-reyaz
Copy link
Author

Whoopsie daisy. The sequence is padded on the left here, so ignore what I said. ;p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant