Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing dm-tree requires bazel on py3.8 #41

Closed
joaogui1 opened this issue May 16, 2020 · 8 comments
Closed

installing dm-tree requires bazel on py3.8 #41

joaogui1 opened this issue May 16, 2020 · 8 comments

Comments

@joaogui1
Copy link
Contributor

Right now it seems one needs bazel to install haiku (even using pip)

@joaogui1 joaogui1 changed the title Problems installing and testing Bazel dependency May 16, 2020
@trevorcai
Copy link
Contributor

tycai:~/src$ python3 -m venv tmp && cd tmp/ && source bin/activate
tycai:~/src/tmp$ which bazel
tycai:~/src/tmp$ pip install --upgrade pip
# some output
tycai:~/src/tmp$ pip install jax jaxlib git+https://github.com/deepmind/dm-haiku
# more output
tycai:~/src/tmp$ python
Python 3.7.7 (default, Mar 10 2020, 13:18:53) 
[GCC 9.2.1 20191109] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import haiku as hk
>>> import jax
>>> import numpy as np
>>> hk.transform(lambda x: hk.Linear(2)(x)).init(jax.random.PRNGKey(428), np.ones((8, 3)))
# some warnings
frozendict({
  'linear': frozendict({
              'b': DeviceArray([0., 0.], dtype=float32),
              'w': DeviceArray([[-0.74963224,  0.05108356],
                                [-0.64863616, -0.96099967],
                                [ 0.69329786,  0.10406391]], dtype=float32),
            }),
})

This looks fine to me. More generally, Haiku is pure-Python, so I'm skeptical that bazel is required if you can install JAX. Can you provide more details?

@joaogui1
Copy link
Contributor Author

Frankly, yesterday it told me to download bazel and after doing that it installed, but today it doesn't seem to be asking for that. I'm not sure what happened and I'm sorry for opening an issue without more investigation

@jessebett
Copy link

@trevorcai I am also running into an issue with bazel dependency related to the dm-tree requirement.

@joaogui1 joaogui1 reopened this May 20, 2020
@jessebett
Copy link

Okay so this installs fine on python 3.7 but on python 3.8 fails with the bazel dependency installing dm-tree

@trevorcai
Copy link
Contributor

@superbobry Mind taking a look at dm-tree on py3.8?

@joaogui1
Copy link
Contributor Author

Thanks @jessebett for getting more info on the issue

@trevorcai trevorcai changed the title Bazel dependency installing dm-tree requires bazel on py3.8 May 20, 2020
@trevorcai
Copy link
Contributor

I see the issue, we're not providing prebuilt wheels for Py3.8+ to PyPI so they're running setup.py on your machine. I'll raise internally to add Py3.8 wheels to Haiku/Sonnet/dm-tree/...

@trevorcai
Copy link
Contributor

#45 removes dm-tree as a Haiku dependency for users, so this shouldn't be an issue for naive installation. (We still depend on dm-tree in the examples dir and in tests, though.)
I'll make a new issue in dm-tree and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants