Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hanabi #61

Closed
veviurko opened this issue Sep 17, 2019 · 2 comments
Closed

Hanabi #61

veviurko opened this issue Sep 17, 2019 · 2 comments

Comments

@veviurko
Copy link

It would be great if we could use this repo with Hanabi. Probably adding some kind of wrapper would be enough.
@lanctot
Copy link
Collaborator

lanctot commented Sep 17, 2019

Welcome @griprox . I'm glad you asked! :) It's in the Call for Contributions. We have an internal version and I just managed to get it working recently.

Should be added in the next update actually, and it will close this issue when it's pushed.

@lanctot
Copy link
Collaborator

lanctot commented Sep 18, 2019

@griprox it's in now. it's an optional game so to enable it you need to follow instructions here: https://github.com/deepmind/open_spiel/blob/e39f9c2950f990c8c974e4bab4968c8ed6ef0638/open_spiel/games/hanabi.h#L28

If you run DQN and/or A2C can you post here or the reddit thread? I'm curious how well they do on Hanabi.

@allychina allychina mentioned this issue Sep 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lanctot @veviurko