Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting number of actions in the domains #73

Closed
michalsustr opened this issue Sep 25, 2019 · 1 comment
Closed

Limiting number of actions in the domains #73

michalsustr opened this issue Sep 25, 2019 · 1 comment

Comments

@michalsustr
Copy link
Collaborator

As pointed out in #51 domains can factorize their actions if there's too many of them per node.

Would you like to impose a limit on that, for example having at most 256 actions per node? The reason why this would practically useful is because pretty much all the algorithms work with some notion of saving a value per action.

@jblespiau
Copy link
Collaborator

jblespiau commented Oct 1, 2019

I do not think preventing games to do that would be beneficial. However, if for some specific work or algorithm, we need to factorize the actions, then it's a good thing to make sure this can be done.

This could be done using an argument to the game, or maybe using a wrapper is there is a good way of doing it. Adding the functions long LegalActionsCount and LegalActionAt(long index) you suggested can also be doable.

If you have a specific need, and found a good way of implementing it for your research/experiments/work, feel free to share it and this can also be included in OpenSpiel.

Feel free to reopen is the answer is not satisfactory for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants