Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of discounted cfr and linear cfr #78

Closed
ai-gamer opened this issue Sep 28, 2019 · 2 comments
Closed

Implementation of discounted cfr and linear cfr #78

ai-gamer opened this issue Sep 28, 2019 · 2 comments
Labels
contribution welcome It's a nice feature! But we do not have the time to do it ourselves. Contribution welcomed!

Comments

@ai-gamer
Copy link
Contributor

I try to implement discounted cfr by writing a subclass of _CFRSolver class. I overwrite the _compute_counterfactual_regret_for_player function. Since linear CFR is just a special case of discounted cfr, so it is also implemented. I am not sure if I implement it in a nice way.

I test it by running on goofspiel4, it gets decent results. Will the implementation be helpful? Should I pull it?

@lanctot
Copy link
Collaborator

lanctot commented Sep 28, 2019

That's awesome!! That sounds like a great way to do it. Yes, please, would love if you turned this into a pull request.

@ai-gamer
Copy link
Contributor Author

I turned it into a pull request. Please check if it works when you get time. Thanks!

@jblespiau jblespiau added the contribution welcome It's a nice feature! But we do not have the time to do it ourselves. Contribution welcomed! label Oct 1, 2019
@lanctot lanctot closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome It's a nice feature! But we do not have the time to do it ourselves. Contribution welcomed!
Projects
None yet
Development

No branches or pull requests

3 participants