You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I want to implement the Xiangqi game. I'm referring the Chess game implementation as an example for Xiangqi. For chess, there is chess folder which has files like chess_board, chess-common. I want to create the same xiangqi folder with same files (my programming skill is not so good, so i'm just mimicking Chess). Will the files be recognized by the compiler when I run build_and_run_tests.sh? How can I make sure that my implementation will be merged into open_spiel? Thanks!
The text was updated successfully, but these errors were encountered:
The files will be found if they are added to the appropriate CMakeLists.txt files. I recommend copying what is done in chess there as well.
Once you are happy with the implementation and all the tests pass, please submit a pull request. Then we will review it and probably ask you to change a few things and then once the fixes are all done we will import it and it gets merged after that.
Hello, I want to implement the Xiangqi game. I'm referring the Chess game implementation as an example for Xiangqi. For chess, there is chess folder which has files like chess_board, chess-common. I want to create the same xiangqi folder with same files (my programming skill is not so good, so i'm just mimicking Chess). Will the files be recognized by the compiler when I run
build_and_run_tests.sh
? How can I make sure that my implementation will be merged into open_spiel? Thanks!The text was updated successfully, but these errors were encountered: