Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Android Basics: Introduction to Room and Flow - grammar #58

Closed
nichojo89 opened this issue Jun 4, 2022 · 2 comments
Closed

Android Basics: Introduction to Room and Flow - grammar #58

nichojo89 opened this issue Jun 4, 2022 · 2 comments
Assignees

Comments

@nichojo89
Copy link

In the "Define the ViewModel" step, there is a sentence that reads
"As the ViewModel class BusScheduleViewModel needs from is meant to be lifecycle aware, it should be instantiated by an object that can respond to lifecycle events."

Should this instead be?
"As the ViewModel class BusScheduleViewModel is meant to be lifecycle aware, it should be instantiated by an object that can respond to lifecycle events."

@shepardsn
Copy link

I agree. Similarly, the sentence after it reads:

If you instantiate it directly in one of your fragments, then your fragment object will have to handle everything all the memory management, which is beyond the scope of what your app's code should do.

and perhaps should be:

If you instantiate it directly in one of your fragments, then your fragment object will have to handle everything, including all the memory management, which is beyond the scope of what your app's code should do.

@osuleymanova osuleymanova self-assigned this Jul 12, 2022
@osuleymanova
Copy link
Contributor

@nichojo89 , @shepardsn
Thank you for reaching out to us. Your typo fix suggestions were reviewed and will be published soon:

Screen Shot 2022-07-12 at 3 11 43 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants