Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

Android Kotlin Fundamentals codelab: #157

Closed
mbegabolawe opened this issue May 11, 2020 · 1 comment
Closed

Android Kotlin Fundamentals codelab: #157

mbegabolawe opened this issue May 11, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@mbegabolawe
Copy link

Describe the problem
The codelab uses deprecated ViewModelProviders.of instead of ViewModelProvider or rather by viewModels

In which lesson and step of the codelab can this issue be found?
Android Kotlin Fundamentals 05.1: ViewModel and ViewModelFactory
Step 9

How to reproduce?
n/a

Versions
n/a

Additional information
Can't find clarity between ViewModelProvider or rather by viewModels. I believe by viewModels is best practice.

codelab: android-kotlin-fundamentals
@GeneAndGoogle GeneAndGoogle added the duplicate This issue or pull request already exists label May 14, 2020
@GeneAndGoogle
Copy link
Contributor

Duplicate of #29

@GeneAndGoogle GeneAndGoogle marked this as a duplicate of #29 May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbegabolawe @GeneAndGoogle