Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to force latest revision #46

Closed
samos123 opened this issue Mar 26, 2021 · 3 comments
Closed

Add ability to force latest revision #46

samos123 opened this issue Mar 26, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@samos123
Copy link

I manually changed traffic rules and afterwards the action won't automatically deploy new revisions to be the latest serving revision. The CLI has a command to automatically make latest the serving revision, it would be great if there was a parameter for the github action called force_latest that would force the latest revision to be the serving revisios by using this command:

gcloud run services update-traffic [[SERVICE] --to-latest
@aurecchia
Copy link

I was looking at the implementation, to add this feature, but from what I saw, think it should already be possible to manage the traffic of the latest revision, as far as I understand.

If either of the revision_traffic or tag_traffic options is set, the code builds a base command similar to the one suggested by @samos123.
Then, in the documentation of gcloud it is stated that one can always refer to the latest revision with LATEST.

Setting revision_traffic to LATEST=100 should do the trick (though I have not checked it myself, yet)

@sethvargo
Copy link
Member

Hi @aurecchia

Yes - that's correct, and that's what gcloud does too. --to-latest is just syntactic sugar.

@rubiagatra
Copy link

should be close the issue then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

No branches or pull requests

5 participants