Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auth precedence for envvar #50

Merged
merged 1 commit into from
Dec 6, 2021
Merged

fix: auth precedence for envvar #50

merged 1 commit into from
Dec 6, 2021

Conversation

bharathkkb
Copy link
Contributor

x-ref: google-github-actions/setup-gcloud#418 (need to update setup-gcloud)

setup-gcloud also sets GOOGLE_GHA_CREDS_PATH and this can lead to other instantiations of setup-gcloud picking this up for auth rather than the explicit key passed in.

@bharathkkb bharathkkb requested a review from a team as a code owner December 4, 2021 01:43
@google-cla google-cla bot added the cla: yes label Dec 4, 2021
@sethvargo sethvargo mentioned this pull request Dec 6, 2021
Closed
@bharathkkb bharathkkb merged commit 75f0480 into main Dec 6, 2021
@bharathkkb bharathkkb deleted the auth-pref branch December 6, 2021 16:55
@google-github-actions-bot google-github-actions-bot mentioned this pull request Dec 6, 2021
Merged
@bharathkkb bharathkkb mentioned this pull request Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch averikitsch is a code owner automatically assigned from google-github-actions/maintainers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bharathkkb @sethvargo