feat: add gcloudRun and use getExecOutput #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
force-pushed
the
sethvargo/output
branch
from
83417d9
to
38427fc
Compare
sethvargo
force-pushed
the
sethvargo/output
branch
6 times, most recently
from
4932e27
to
87928e7
Compare
|
@bharathkkb these failing tests are also failing at HEAD (I just kicked off that run). It looks like a credential or something might have expired? |
|
@sethvargo yup they expired. I will update in a bit |
|
Yay green now :) |
|
@bharathkkb can I get a 👍 on this now that tests are passing? |
bharathkkb
approved these changes
Feb 3, 2022
This introduces two new functions `gcloudRun` and `gcloudRunJSON` which use `@actions/exec#getExecOutput` to execute gcloud commands. It checks if the command was successful. On failure, it throws an error and prints stderr and stdout. On success, it returns the stderr, stdout, and combined output. Introducing this function also greatly simplified some of the other functions, which had a lot of duplicate logic, etc.
sethvargo
force-pushed
the
sethvargo/output
branch
from
87928e7
to
81e57cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two new functions
gcloudRunandgcloudRunJSONwhich use@actions/exec#getExecOutputto execute gcloud commands. It checks if the command was successful. On failure, it throws an error and prints stderr and stdout. On success, it returns the stderr, stdout, and combined output.Introducing this function also greatly simplified some of the other functions, which had a lot of duplicate logic, etc.
I also refactored the tests a bit to reduce the number of times we actually install gcloud. This made the tests significantly faster (~5min -> ~40s).