Retire `pedantic` in favor of `flutter_lints` #210

JlUgia · 2023-08-01T18:40:05Z

Raised by #182.

This PR also includes:

Updating the list of analysis checks based on the recommendations from Dart and Flutter
Update tests to use the new recommended process to create mock channel handlers
Reduce the use of dynamic where possible (eg.: results from json [de]coding operations)
Expand the use of const on widgets
Avoid exposing the State any more than necessary

…and avoid exposing the private type in the public API

…aryMessengerBinding.instance.defaultBinaryMessenger

JlUgia added 9 commits August 1, 2023 20:29

Remove pedantic (deprecated) in favor of flutter_lints for linting

a05cd55

Include required libraries

7f3ae20

Use const when possible with widgets

5495afd

Use the resulting State as the type parameter in the application UI, …

a9b7c95

…and avoid exposing the private type in the public API

Use explicit types

6e5f63d

Style changes and copyright notes

e4df54d

Avoid null returning functions

dafefea

Local variables don't benefit from the private pseudo-modifier

64f9a9c

Sunset the deprecated mock channel process in favor of TestDefaultBin…

11179c1

…aryMessengerBinding.instance.defaultBinaryMessenger

JlUgia requested a review from dmengelt August 1, 2023 18:40

dmengelt approved these changes Sep 29, 2023

View reviewed changes

JlUgia merged commit e907abc into main Jan 17, 2024
1 check passed

JlUgia deleted the update_linting branch January 17, 2024 13:18

Provide feedback