Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depth is constant each width #13

Closed
yumion opened this issue Jul 29, 2020 · 2 comments
Closed

depth is constant each width #13

yumion opened this issue Jul 29, 2020 · 2 comments

Comments

@yumion
Copy link

yumion commented Jul 29, 2020

Hello, thank you for releasing a implementation.

In my understanding, we change number of op as depth each width , however this code should be same depth each width here.

depth = depth if depth > 0 else np.random.randint(1, 4)

So, we change code like below, right?

depth = np.random.randint(1, depth + 1 if depth > 0 else 4)

Best, regard.

@normster
Copy link
Collaborator

Thanks for pointing this out, you're completely right. Feel free to submit a PR or I can make the change when I get a chance.

@normster
Copy link
Collaborator

Hi @yumion, I took a closer look and the suggested fix doesn't address the bug of overwriting depth on the first branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants