Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing with the best model #8

Closed
LeeDoYup opened this issue Mar 31, 2020 · 4 comments
Closed

Testing with the best model #8

LeeDoYup opened this issue Mar 31, 2020 · 4 comments

Comments

@LeeDoYup
Copy link

I found that cifar.py code does not test the performance with the best model.

augmix/cifar.py

Line 431 in 7c84885

test_c_acc = test_c(net, test_data, base_c_path)

In addition, why the validation set of CIFAR is not used in the model selection ??

@cygerts
Copy link

cygerts commented May 21, 2020

I think they choose the model from 100th epoch.
From the paper: "The All Convolutional Network and Wide ResNet train for 100 epochs,
and the DenseNet and ResNeXt require 200 epochs for convergence"

@LeeDoYup
Copy link
Author

I think it's much unfair, because the code evenly save the best model.

augmix/cifar.py

Lines 413 to 414 in 7c84885

if is_best:
shutil.copyfile(save_path, os.path.join(args.save, 'model_best.pth.tar'))

We can just use the best model in evaluation :) !!

@LeeDoYup
Copy link
Author

I also checked, the selection of the best model doesn't change augmix's performances on test_c.

@normster
Copy link
Collaborator

Hi @LeeDoYup, there isn't much of a difference between the best and latest models so we just evaluate on the latest model checkpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants