Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asterix/1 dataset broken? #28

Open
dssrgu opened this issue Apr 13, 2022 · 3 comments
Open

Asterix/1 dataset broken? #28

dssrgu opened this issue Apr 13, 2022 · 3 comments

Comments

@dssrgu
Copy link

dssrgu commented Apr 13, 2022

Hi,

I tried reproducing the offline REM results with Asterix/1 dataset by using the command below:

python -um batch_rl.fixed_replay.train \
  --base_dir=/tmp/batch_rl \
  --replay_dir=/data_large/readonly/atari/Asterix/1 \
  --agent_name=multi_head_dqn \
  --gin_files='batch_rl/fixed_replay/configs/rem.gin' \
  --gin_bindings='FixedReplayRunner.num_iterations=1000' \
  --gin_bindings='atari_lib.create_atari_environment.game_name = "Asterix"'

But could not reproduce the results (about avg 50 return on 200th iteration).
Meanwhile, I can reproduce the results in other Asterix datasets (e.g. Asterix/2, ...).
Could you check if the Asterix/1 dataset has some errors?

Thank you!

@agarwl
Copy link
Collaborator

agarwl commented Apr 15, 2022

Hmm .. I'm also not sure what could be causing the issue but we have used Asterix/1 for some of our recent ICLR/NeurIPS papers and it does seem to replicate internally -- That said, I do know CQL authors had difficulty replicating the results on Asterix, so there might be some chance the dataset might be corrupted. If this is time sensitive, feel free to ignore this specific run. I'll also compare the checksums of the public data and the internal data.

One thing that you can check is whether the clipped rewards match in the dataset with the TFDS version of the dataset (see this colab for an example of how to load the dataset).

@dssrgu
Copy link
Author

dssrgu commented Apr 17, 2022

Thank you for the response!

I'll ignore this dataset for right now.
Just to let you know, below is the training curve for Asterix/1 and Asterix/2:

Screen Shot 2022-04-17 at 6 53 51 PM

Thank you!

@agarwl
Copy link
Collaborator

agarwl commented Jun 1, 2023

This is probably too late but I re-uploaded the entire dataset for run 1 from the copy we have internally. Hopefully, this would fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants