Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential issue with FactorVAE discriminator loss #16

Closed
psoulos opened this issue Oct 5, 2019 · 1 comment
Closed

Potential issue with FactorVAE discriminator loss #16

psoulos opened this issue Oct 5, 2019 · 1 comment

Comments

@psoulos
Copy link

psoulos commented Oct 5, 2019 •
edited

Hello,

I am writing about the discrimnator loss for FactorVAE. Should the two values in discr_loss be negative? It seems like the probs_z[:, 0] is the probability that the sample comes from the joint distribution, but the line that I linked would encourage the values in probs_z[:, 0] to go towards 0 instead of 1.
@psoulos
Copy link
Author

psoulos commented Oct 5, 2019

Sorry, I just realized that -discr_loss is minimized instead of discr_loss

@psoulos psoulos closed this as completed Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@psoulos