Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in conv_encoder architecture? #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

travers-rhodes
Copy link

Thank you so much for making this library!

I was trying to run baselines using this library's "conv_encoder" architecture for the VAE and noticed that that architecture (including in the publicly available models at, for example, https://storage.googleapis.com/disentanglement_lib/unsupervised_study_v1/0.zip) don't seem to match the architecture described in https://arxiv.org/pdf/1811.12359.pdf in Table 2 of the appendix.

In particular, it looks like the last two Conv2D embedding layers have a kernel of 2x2 instead of 4x4.

I have no idea if it makes any important difference, but my intuition is telling me that 4x4 might make more sense (as shown in the attached pull request), so will probably make that change on my end. I just wanted to reach out and see if you would possibly have time to check my thought process there.

Thanks so much!

@google-cla
Copy link

google-cla bot commented May 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 16, 2021
@travers-rhodes
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant