Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float representation giving different dimensional vector for each scenario. #33

Closed
vishalbidawatka opened this issue Jul 1, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@vishalbidawatka
Copy link

vishalbidawatka commented Jul 1, 2019

If you choose a particular scenario like "empty goal close", the env.observation space shows 115 as the dimension size of the float representation but the the returned state is 39-dimensional vector and the number is different for another scenario. Why is that ?

@AntonRaichuk
Copy link
Collaborator

That representation is indeed supposed to work only for 11 vs 11. Some of the features that it has are coordinates of 11 players on your team as well as on the opponents.
When you go to a different scenario (in terms on number of players) obviously the dimensionality wont be the same.

We can make a simple change to backfill missing slots with say -1 values. So at least it does not crash. Expect this change in the next release (hopefully this week)

@cyfra cyfra added the bug Something isn't working label Jul 4, 2019
@qstanczyk
Copy link
Collaborator

We just pushed a new release, the fix is included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants