Enhacement of utils.py and interpolator_cli.py #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tqdm argument to show interpolation progress.
Added tqdm argument to show interpolation progress.
|
Can you rebase to head first, and make the changes? Currently, there are more changes (in both files) than just enabling use of |
Hey friend! When I open up the pull request tab, it won't let me submit one unless I click on compare across forks, and when I do that, even with the |
|
Thanks! See 89c39f2 |
|
Nice! Thanks for fixing my code also lol!Sent from my iPhoneOn Nov 30, 2022, at 5:18 PM, Fitsum Reda ***@***.***> wrote:
Thanks! See 89c39f2
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhacement of utils.py and interpolator_cli.py, this PR adds tqdm to the interpolation function and the frame compilation function to show a progress bar while loading. Very minor addition, but works well for my taste!