Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enas_lm child model #67

Closed
HaleyQH opened this issue Oct 22, 2019 · 1 comment
Closed

Enas_lm child model #67

HaleyQH opened this issue Oct 22, 2019 · 1 comment

Comments

@HaleyQH
Copy link

HaleyQH commented Oct 22, 2019

In the child.py file, why w_skip[0] is not used for L2 weight reg ?
var_s = [w_prev] + w_skip[1:]

# extract the relevant variables, so that you only do L2-reg on them.

Does w_skip[0] means the weight of node 1 and node 2 (as the red arrow shows )?

enas

@ZhiqingXiao
Copy link

I also noticed bugs in calculating the L2 regularization.

In child.py:
https://github.com/google-research/google-research/blob/master/enas_lm/src/child.py#L318

self.l2_reg_loss = tf.add_n([tf.nn.l2_loss(w ** 2) for w in var_s])

The regularization is implemented as "l4" regularization.

However in fixed_lib is correct:
https://github.com/google-research/google-research/blob/master/enas_lm/src/tpu/fixed_lib.py#L409

@phthhieu
@melodyguan

@HaleyQH HaleyQH closed this as completed Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants