Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The implementation details in the code. #2

Closed
SUNJIMENG opened this issue Jun 28, 2021 · 1 comment
Closed

The implementation details in the code. #2

SUNJIMENG opened this issue Jun 28, 2021 · 1 comment

Comments

@SUNJIMENG
Copy link

Excuse me, line 216 in xmc_net.py, "x = dense_fn(self.gf_dim * 16 * 4 * 4)(z)", which input the noise "z" into the linear layer. However, Table 7 in supp shows that the input is the concatenation of noise and reshaped condition. I wonder which one is right.

@kohjingyu
Copy link
Contributor

Thanks for catching this. In this case, the code is correct - the input to the linear layer is just z. However, I believe there won't be a significant effect on results either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants