Fix counting stage execs for user inserts #73
Conversation
Pretty obvious, because of the number of iterations of the outer loop few lines later: `for (i = 0; i <= len; i++) {` Without the fix the progress can (and does for me) go over 100% otherwise.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
No. It would make it inconsistent with rest of the afl code.
…On Tue, 4 Aug 2020, 02:15 Max Moroz, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In afl-fuzz.c
<#73 (comment)>:
> @@ -5980,7 +5980,7 @@ static u8 fuzz_one(char** argv) {
stage_name = "user extras (insert)";
stage_short = "ext_UI";
stage_cur = 0;
- stage_max = extras_cnt * len;
+ stage_max = extras_cnt * (len + 1);
would it be better to fix the loop condition instead (line 5989) ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#73 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA254SZ467QBGR4YP4BKXDR65HKTANCNFSM4KSYVS5A>
.
|
Thanks @lszekeres for taking a look and sorry @baryluk for the confusion from my end. |
Fix counting stage execs for user inserts (google#73)
Pretty obvious, because of the number of iterations of the outer loop few lines later:
for (i = 0; i <= len; i++) {
Without the fix the progress can (and does for me) go over 100% otherwise.