Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling EarlGrey.swift installation via Cocoapods #668

Closed
bootstraponline opened this issue Dec 12, 2017 · 1 comment
Closed

Allow disabling EarlGrey.swift installation via Cocoapods #668

bootstraponline opened this issue Dec 12, 2017 · 1 comment

Comments

@bootstraponline
Copy link
Contributor

bootstraponline commented Dec 12, 2017

target 'SoGrey' do
    project 'Frameworks/SoGrey/SoGrey.xcodeproj'
    pod 'EarlGrey', '~> 1.1'
end

abstract_target 'common_ui_tests' do
    target 'TeacherUITests' do
      pod 'SwiftProtobuf', '~> 0.9.904'
      pod 'EarlGrey', '~> 1.1'
      project 'rn/Teacher/ios/Teacher.xcodeproj'
    end
end

EarlGrey.swift is provided by a shared framework SoGrey so we don't want EarlGrey.swift from the gem. You can see in the podfile, EarlGrey.swift is added to the SoGrey target. Then we have a TeacherUITests that should not have EarlGrey.swift

There should be a way to tell EarlGrey to not add EarlGrey.swift on certain targets.

@bootstraponline
Copy link
Contributor Author

The copy script also needs to be opt-out. When using a shared framework target, the copy script has the wrong framework path. There's currently no opt-out so cocoapods will inject code that breaks the tests on each pod install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant