Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMA Extension behaving weird when backgrounding midrolls with multiple ads #4140

Closed
victorraft opened this issue Apr 17, 2018 · 19 comments
Closed
Assignees

Comments

@victorraft
Copy link

victorraft commented Apr 17, 2018

I noticed some weird behavior in the streams that have multiple sequential ads in the midroll (those sample tags with mid-roll standard/optimized pod with 3 ads for example).
When I minimize the demo app right when the midroll starts playing and then put the app back in foreground the player doesn't seem to recover correctly.
Sometimes it waits for midroll 1/3 to finish, then skips 2/3 and go straight to 3/3 and stop showing the label that should read Ad 3 of 3. Sometimes it freezes on midroll 3/3 and never resumes. When the midroll finishes the content video resumes playback but you can never see the playback control bar again when you click the screen.
I seem to be getting a random combination of the possibilities above each time I try it.

I was testing this because we received reports that similar issues happened in our app when pressing Skip Ad in a midroll that has multiple ads. It is very hard to find adtags with skippable midrolls, though, so I'm having issues reproducing it. Do you think it could be the same issue?

Reproduction steps

Use the demo app, version 2.7.3.
Go to IMA Sample ad tags and pick VMAP pre-roll single ad, mid-roll standard pod with 3 ads, post-roll single ad (can be any adtag that has mid-roll pod with 3 ads).
Wait for the preroll to finish.
Skip to somewhere around the middle of the video (any part that's after the midroll yellow mark).
As soon as midroll 1/3 starts playing press home to minimize the app.
Open the app again and wait for the playback to resume.

Device(s) and version(s) of Android being used

I tested on Android Emulators with android api level 24 and P.

@andrewlewis andrewlewis self-assigned this Apr 17, 2018
@andrewlewis
Copy link
Collaborator

We've seen issues with IMA unexpectedly skipping ads in a midroll before, so this may be related.

@victorraft
Copy link
Author

Is this a priority at the moment? Do you have some sort of idea of when this issue is going to be addressed?
Thanks, @andrewlewis

@andrewlewis
Copy link
Collaborator

It's possible the issue was addressed in IMA 3.8.5. It would help speed things up if you try to reproduce this on dev-v2 having set ImaAdsLoader.DEBUG to true, and post the logcat captured during a problematic playback.

@victorraft
Copy link
Author

The issue still happens in dev-v2. Here are the logs, starting right before the seek is done and stopping when the last midroll piece is finished: https://gist.github.com/victorraft/1d807593a89a7d51c5195b017d66b058

@andrewlewis
Copy link
Collaborator

[Internal reference: b/78006594]

@na-in-lee
Copy link

na-in-lee commented May 15, 2018

#3764 comment
[2 ads - just linear vast not vmap midroll]

When the user presses the home button (background) during play first ad, the player automatically paused, user screen turned on (foreground), The player shows only the first ad and goes to the content(without play the second ad)
Ad skins also become skip ad and change 1/2 to 2/2 while the first ad is playing.

Test Ad URL

@andrewlewis
Copy link
Collaborator

The IMA team is now investigating what sounds like the same issue. I'll update this if we get more information. Thanks for your patience.

@OrenMe
Copy link

OrenMe commented Jun 1, 2018

@andrewlewis can you share a link to tracking bug for the issue if avilable?

@andrewlewis
Copy link
Collaborator

It's an internal bug but I'll keep this issue updated with anything relevant that comes up.

@andrewlewis
Copy link
Collaborator

A server-side fix for skipped midroll ads was recently rolled out to the IMA JavaScript code, but unfortunately this still seems to be reproducible. I've filed another issue to follow up (internal: b/110400963).

@christianb
Copy link

We also have the issue that our midroll ads stopping before they reache the end.
We are using the ExoPlayer:2.7.1, with Ima-Extension.

@andrewlewis
Copy link
Collaborator

@christianb Are you seeing that a midroll is skipped when the player is backgrounded while playing a previous midroll in the same ad group? If not it might be different from this issue, so please file a new issue and include the ad tag and steps to reproduce.

@christianb
Copy link

christianb commented Jul 2, 2018

@andrewlewis We could solve the problem. Was an issue on our side. We removed the Ad view too early. That made the Ad breaking before the end. Now everything works fine :)

@andrewlewis
Copy link
Collaborator

This is still reproducible with IMA SDK 3.9.4 including in the official IMA sample app, and I think the same issue is occurring with @na-in-lee's ad tag above. I'll post an update here when we have more information about what is going on. [Internal: b/110400963]

@andrewlewis
Copy link
Collaborator

Note: this is still reproducible using IMA SDK 3.10.2.

@Maneesh528

This comment has been minimized.

@andrewlewis
Copy link
Collaborator

Just a quick update: the likely root cause of this has been identified but fixing it is probably going to need to wait until some structural improvements to how preloading works in the IMA SDK have been completed.

@andrewlewis
Copy link
Collaborator

I've verified this is fixed by migrating to the new IMA SDK preloading APIs (fa7d26d), and that change should be in a release soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants