-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve parsing speed for large WebVTT files #4948
Comments
When my vtt subtitle file is about 4M, it takes 30 seconds to load. |
Please provide complete information as requested in the issue template. The issue template can be found here. |
Issue descriptionWhen i try to load a subtitles which size over than 4M, the subtitles will show untill fully loaded. before loading successfully, there will no any signal shows subtitles is loading. Reproduction stepsOpen the video and select subtitle. Link to test contentEmail. Version of ExoPlayer being used2.8.4 Device(s) and version(s) of Android being usedFire Tv(7.1.2) A full bug report captured from the deviceNo error. |
It takes about 3.5 seconds on a Galaxy S8. It looks like this is just how long it takes for our current implementation to parse the VTT file, which is pretty huge (over 127 thousand lines). If it needs to be downloaded as well, that will add additional delay. I don't think we have any plans to process such files incrementally. It is probably possible to make the parsing code in Marking as a low priority enhancement. We would accept a high quality pull request that improves the speed of the parsing code. |
After selecting the specified subtitle, it will appear 5-10 seconds later, but the audio is still synchronized after the appearance. I use
TrackSelectionView
to switch the subtitle. The version number is2.8.4
.I am testing on Fire TV.
The text was updated successfully, but these errors were encountered: