Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Program Stream Map for track identification in MPEG-2 PS streams #5459

Open
rej0902 opened this issue Jan 31, 2019 · 3 comments
Open
Assignees

Comments

@rej0902
Copy link

rej0902 commented Jan 31, 2019

Hi, when i testing this demo app for http://commondatastorage.googleapis.com/wvmedia/sintel_main_720p_4br_tp.wvm playing test

I know this file type not supported. but any error code not callback and return.

check playing link.

@AquilesCanta
Copy link
Contributor

AquilesCanta commented Jan 31, 2019

I think the issue here is that we are failing to identify the h264 video stream. One way of fixing this would be actually parsing the program stream map (stream id 188) and using that to identify the stream type of the other stream ids.

Note, this stream will work (codec support aside) if the following path is added here:

 } else if ((streamId & VIDEO_STREAM_MASK) == 0xe0) {
          elementaryStreamReader = new H264Reader(new SeiReader(Collections.emptyList()), false, false);
          foundVideoTrack = true;
          lastTrackPosition = input.getPosition();
}

I'll mark this as an enhancement. Once I get some time to do it, i'll revisit this. In the meantime, feel free to send a Pull Request our way.

@seose
Copy link

seose commented Feb 7, 2019

Greate Infos
thanks~

@ojw28
Copy link
Contributor

ojw28 commented Apr 5, 2019

@AquilesCanta - Please update the title of this issue to reflect what the enhancement is. Thanks!

@AquilesCanta AquilesCanta changed the title Why ErrorCode not Callback in ExoPlayer Parse Program Stream Map for track identification in MPEG-2 PS streams Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants