Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayerView: Provide option to show default artwork when no prepared player is attached #6265

Open
roninshahi opened this issue Aug 5, 2019 · 13 comments
Assignees

Comments

@roninshahi
Copy link

roninshahi commented Aug 5, 2019

hi
I wanna show a preview bitmap of a video in exoplayer.i have the bitmap and I use

playerview.setUseArtwork(true);
playerview.setDefaultArtwork(bitmap); 

but it doesn't work.
***i havent write any code to connect playerview to exoplayer.
I used an image view to show the preview and then hide it but it wasn't good.

@ojw28
Copy link
Contributor

ojw28 commented Aug 5, 2019

Artwork passed to setDefaultArtwork is only displayed when the player is connected to the view and prepared (and if the prepared media doesn't contain any artwork of its own).

I'll mark this as an enhancement to provide an option for the default artwork to also be displayed when there's no player and when the player is not prepared.

@ojw28 ojw28 self-assigned this Aug 5, 2019
@ojw28 ojw28 changed the title artwork dosnt show the preview of a video PlayerView: Provide option to show default artwork when no prepared player is attached Aug 5, 2019
@roninshahi
Copy link
Author

ty

@HiroyukiTamura
Copy link

I'll mark this as an enhancement to provide an option for the default artwork to also be displayed when there's no player and when the player is not prepared.

any updates?

@KgotsoK
Copy link

KgotsoK commented Sep 15, 2020

This should be prioritized...

@elmateo487
Copy link

This seems like such low hanging fruit. In order to show an image on the view, such as when there is no internet and the stream isn't loading, we have to wrap the view with another image view. IMO, this view should just be displayed the second the player is displayed. Then we can listen for playback errors and show the whole PlayerView, which would then have an image on it

@grndvl1
Copy link

grndvl1 commented Jun 18, 2021

Yeah, I'm surprised there is no way to show a placeholder image then when prepare and play go, hide that image and show video. Should be an option unless there is something blocking that from happening. I will just wrap an image view and show hide when player is prepping.

@lmj0011
Copy link

lmj0011 commented Jul 15, 2021

#4639

@ParticleCore
Copy link

this issue was opened in 2019.
it's currently 2021, almost ending, and still no proper solution for this. forcing the use of an artwork by means of loading a chunk of video data can be quite expensive if it is a high resolution video, instead of just keeping the player unprepared and showing a custom image.

@grndvl1

This comment has been minimized.

@yuyuan20
Copy link

Any updates on this issue?

@SaNu-hIT
Copy link

SaNu-hIT commented Apr 7, 2022

Any update on this issue ?

1 similar comment
@mohodroid
Copy link

Any update on this issue ?

@ojw28 ojw28 assigned icbaker and unassigned ojw28 Jul 7, 2022
@imansdn
Copy link

imansdn commented Jan 8, 2023

Aw, shoot it's still open, now I have to go for a workaround! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

14 participants