Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev v2 truehd #9496

Merged
merged 2 commits into from Oct 14, 2021
Merged

Dev v2 truehd #9496

merged 2 commits into from Oct 14, 2021

Conversation

g-lass
Copy link
Contributor

@g-lass g-lass commented Sep 27, 2021

reopening #9415 that was automatically closed after deleting the branch by mistake.

the latest commit do address the comments made in #9415 .
To summarize , it does :

  • fix the MP4 Extractor test : after re-muxing the TrueHD test vector , all tests are now passing
  • implement a TrueHD Rechunker for MP4 Extractor as done in the pre-existing MKV extractor

@google-cla google-cla bot added the cla: yes label Sep 27, 2021
@ojw28 ojw28 requested a review from kim-vde September 28, 2021 12:45
g-lass and others added 2 commits September 30, 2021 16:17
@g-lass
Add MP4 extraction of Dolby TrueHD samples
13f4c83 
Extract 16 access units per readSample call to align
with what's done in MKV extraction.

Signed-off-by: glass <glass@dolby.com>
Add Dolby TrueHD extraction test for MP4 files.
d6bc49c 
Signed-off-by: glass <glass@dolby.com>
@g-lass
Copy link
Contributor Author

g-lass commented Sep 30, 2021 •
edited

the latest drop

  • cuts the testfile to less than 100kB (418ms total duration).
  • fixes a crash observed after cutting the testfile.
  • clarifies why I set the number of channels to 2 irrespective of the stream content.
  • addresses a couple of warnings from the compiler.

@kim-vde kim-vde merged commit 059dfae into google:dev-v2 Oct 14, 2021
@google google locked and limited conversation to collaborators Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kim-vde kim-vde kim-vde left review comments

Assignees

@kim-vde kim-vde

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@g-lass @kim-vde