Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong transitive dependency protobuf #23

Closed
SimonMarquis opened this issue Oct 5, 2022 · 3 comments
Closed

Wrong transitive dependency protobuf #23

SimonMarquis opened this issue Oct 5, 2022 · 3 comments

Comments

@SimonMarquis
Copy link

馃憢 Hi,
In the 1.4 release, you mentionned

Replaced dependency on protobuf-java by a dependency on protobuf-javalite

But in fact, this is not what has been done in acb188b#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8L137-R138

-      <artifactId>protobuf-java</artifactId>
-      <version>3.14.0</version>
+      <artifactId>protobuf-lite</artifactId>
+      <version>3.0.1</version>

The switch is from protobuf-java to protobuf-lite.
And this is still causing errors when using with firebase-perfs (where GeneratedMessageLite is coming from your transitive dependency instead of firebase's):

java.lang.NoSuchMethodError: 'void com.google.protobuf.GeneratedMessageLite.registerDefaultInstance(java.lang.Class, com.google.protobuf.GeneratedMessageLite)'	
at com.google.firebase.perf.v1.TraceMetric.<clinit>(TraceMetric.java:1945)	
at com.google.firebase.perf.metrics.TraceMetricBuilder.build(TraceMetricBuilder.java:39)	
at com.google.firebase.perf.metrics.Trace.stop(Trace.java:258)

It's only "recently" that the correct dependency has been restored:
4d0fe88

-      <artifactId>protobuf-lite</artifactId>
-      <version>3.0.1</version>
+      <artifactId>protobuf-javalite</artifactId>
+      <version>3.20.0</version>

Do you have any plan to release this fix?
Regards

@SimonMarquis SimonMarquis changed the title Wrong transitive dependency Wrong transitive dependency protobuf Oct 5, 2022
@nymanjens
Copy link
Collaborator

Thanks for letting me know you're having this issue! I'll start the process for releasing the next version.

@nymanjens
Copy link
Collaborator

Looks like @GediminasZukas added this via #21, but I forgot to trigger a release after this change.

@nymanjens
Copy link
Collaborator

I sent a new release v1.9 to the Maven repositories. It usually takes about a day to show up in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants