Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pager] View remains scrollable when swipping between pages #1128

Closed
Doomsdayrs opened this issue Apr 14, 2022 · 18 comments
Closed

[Pager] View remains scrollable when swipping between pages #1128

Doomsdayrs opened this issue Apr 14, 2022 · 18 comments
Assignees
@bentrengrove
Labels
stale Stale issues which are marked for closure

Comments

@Doomsdayrs
Copy link

Doomsdayrs commented Apr 14, 2022 •
edited
Loading

Description
As the title describes, this happens specifically with a vertical pager.
This also makes it difficult to swap between pages (I presume?), as it becomes a struggle to swipe.

Steps to reproduce
Manage to get two pages of webviews stuck in the middle

Expected behavior
View does not remain scroll-able & pager completes swipe

Additional context
#1063 seems related

Video1 of one of my users doing this. Stuck between two web views.
@Doomsdayrs Doomsdayrs changed the title [Pager] Web inner content becomes scrollable when swipping between pages [Pager] Web inner content remains scrollable when swipping between pages Apr 19, 2022
@Doomsdayrs Doomsdayrs changed the title [Pager] Web inner content remains scrollable when swipping between pages [Pager] View remains scrollable when swipping between pages Apr 19, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label May 20, 2022
@Doomsdayrs
Copy link
Author

#1127 (comment)

Following instructions here, without the removal of code will show the issue

@github-actions github-actions bot removed the stale Stale issues which are marked for closure label May 21, 2022
@Doomsdayrs Doomsdayrs mentioned this issue May 24, 2022
Open
@Doomsdayrs
Copy link
Author

This is likely related to how nestedScroll is handled.

Having as stated here, I think this would solve the issue?

@Doomsdayrs
Copy link
Author

I have attempted to add a connection via NestedScrollConnection & NestedScrollDispatcher

I realized that the functionality does not seem to work well with verticalScroll components. Thus I am now stuck.

@github-actions
Copy link

github-actions bot commented Jul 3, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Jul 3, 2022
@Doomsdayrs
Copy link
Author

Bump.

@github-actions github-actions bot removed the stale Stale issues which are marked for closure label Jul 4, 2022
@andkulikov
Copy link
Collaborator

Seems like issue with a WebView similarly to 1127?

@Doomsdayrs
Copy link
Author

Seems like issue with a WebView similarly to 1127?

#1127 is due to the webview not constraining properly, instead just matching the max height possible at any time. Which can lead to an infinite page.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Aug 22, 2022
@Doomsdayrs
Copy link
Author

Ehm, bump to reopen

@bentrengrove bentrengrove reopened this Aug 28, 2022
@bentrengrove bentrengrove removed the stale Stale issues which are marked for closure label Aug 28, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Sep 28, 2022
@bentrengrove bentrengrove removed the stale Stale issues which are marked for closure label Sep 28, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Oct 29, 2022
@github-actions github-actions bot closed this as completed Nov 4, 2022
@Doomsdayrs
Copy link
Author

Sigh, bump as still occurs

@bentrengrove bentrengrove reopened this Nov 4, 2022
@bentrengrove bentrengrove removed the stale Stale issues which are marked for closure label Nov 4, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Dec 5, 2022
@Doomsdayrs
Copy link
Author

silly github, this is not stale

@bentrengrove bentrengrove removed the stale Stale issues which are marked for closure label Dec 5, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Jan 20, 2023
@bentrengrove bentrengrove removed the stale Stale issues which are marked for closure label Jan 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Mar 7, 2023
@Palloxin
Copy link

Palloxin commented May 12, 2023 •
edited
Loading

Bump, it still occurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bentrengrove bentrengrove

Labels
stale Stale issues which are marked for closure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bentrengrove @andkulikov @Doomsdayrs @Palloxin